Skip to content

[GL] Deal with non existing path for ffmprg in VideoRecorderFFMPEG #5870

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
fredroy merged 1 commit into from
Jan 20, 2026
Merged

[GL] Deal with non existing path for ffmprg in VideoRecorderFFMPEG #5870

fredroy merged 1 commit into from
Jan 20, 2026
+12 −11

Conversation

@bakpaul
Copy link
Contributor

@bakpaul bakpaul commented Jan 19, 2026

Take special case where given path isn't empty but doesn't point to a real file

By submitting this pull request, I acknowledge that
I have read, understand, and agree SOFA Developer Certificate of Origin (DCO).

Reviewers will merge this pull-request only if

  • it builds with SUCCESS for all platforms on the CI.
  • it does not generate new warnings.
  • it does not generate new unit test failures.
  • it does not generate new scene test failures.
  • it does not break API compatibility.
  • it is more than 1 week old (or has fast-merge label).

@bakpaul bakpaul added pr: fast merge Minor change that can be merged without waiting for the 7 review days pr: status to review To notify reviewers to review this pull-request pr: backport todo This PR will be backported into the release preceeding its milestone. labels Jan 19, 2026
@fredroy
Copy link
Contributor

fredroy commented Jan 19, 2026

[ci-build]

@fredroy fredroy added pr: status ready Approved a pull-request, ready to be squashed and removed pr: status to review To notify reviewers to review this pull-request labels Jan 20, 2026
@fredroy fredroy merged commit 562a47e into sofa-framework:master Jan 20, 2026
17 of 22 checks passed
bakpaul added a commit that referenced this pull request Jan 20, 2026
@bakpaul
[GL] Deal with non existing path for ffmprg in VideoRecorderFFMPEG (#…
54a95c8 
…5870)

Take special case where given path isn't empty but doesn't point to a real file
@bakpaul bakpaul added pr: backport done This PR has been backported into the release before its milestone. and removed pr: backport todo This PR will be backported into the release preceeding its milestone. labels Jan 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fredroy fredroy fredroy approved these changes

Assignees

No one assigned

Labels

pr: backport done This PR has been backported into the release before its milestone. pr: fast merge Minor change that can be merged without waiting for the 7 review days pr: status ready Approved a pull-request, ready to be squashed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@bakpaul @fredroy