Skip to content

[GL] Deal with non existing path for ffmprg in VideoRecorderFFMPEG #5870

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
fredroy merged 1 commit into from
Jan 20, 2026
+12 −11
Merged

[GL] Deal with non existing path for ffmprg in VideoRecorderFFMPEG #5870

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 12 additions & 11 deletions Sofa/GL/src/sofa/gl/VideoRecorderFFMPEG.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,23 +87,23 @@ bool VideoRecorderFFMPEG::init(const std::string& ffmpeg_exec_filepath, const st
m_ffmpegBuffer = new unsigned char [m_ffmpegBufferSize];

m_FrameCount = 0;

std::string extension;
#ifdef WIN32
extension = ".exe";
#endif
m_ffmpegExecPath = ffmpeg_exec_filepath;
if(m_ffmpegExecPath.empty())
{
std::string extension;
#ifdef WIN32
extension = ".exe";
#endif
m_ffmpegExecPath = helper::Utils::getExecutablePath() + "/ffmpeg" + extension;
if(!FileSystem::isFile(m_ffmpegExecPath, true))
{
msg_warning("VideoRecorderFFMPEG")<< "ffmpeg hasn't been found automatically. Falling back to simply calling ffmpeg"<< extension <<" and hope that the OS finds it on its own. " ;
// Fallback to a relative FFMPEG (may be in system or exposed in PATH)
m_ffmpegExecPath = "ffmpeg" + extension;
}
}
if(!FileSystem::isFile(m_ffmpegExecPath, true))
{
msg_warning("VideoRecorderFFMPEG")<< "ffmpeg hasn't been found automatically. Falling back to simply calling ffmpeg"<< extension <<" and hope that the OS finds it on its own. " ;
// Fallback to a relative FFMPEG (may be in system or exposed in PATH)
m_ffmpegExecPath = "ffmpeg" + extension;
}


std::stringstream ss;
ss << m_ffmpegExecPath
<< " -r " << m_framerate
Expand All @@ -123,6 +123,7 @@ bool VideoRecorderFFMPEG::init(const std::string& ffmpeg_exec_filepath, const st
#else
m_ffmpeg = popen(command_line.c_str(), "w");
#endif

if (m_ffmpeg == nullptr) {
msg_error("VideoRecorderFFMPEG") << "ffmpeg process failed to open (error " << errno << "). Command line : " << command_line;
return false;
Expand Down
Loading