Skip to content

Conversation

@AvivYossef-starkware
Copy link
Contributor

No description provided.

@reviewable-StarkWare
Copy link

This change is Reviewable

@github-actions
Copy link

github-actions bot commented Oct 19, 2025

Benchmark movements: No major performance changes detected.

@AvivYossef-starkware AvivYossef-starkware force-pushed the aviv/bump_google_cloud_version branch 2 times, most recently from 19d43f5 to 7b443ef Compare October 19, 2025 11:31
@AvivYossef-starkware AvivYossef-starkware force-pushed the aviv/upload_input_files branch 3 times, most recently from cabf86b to 6721c60 Compare October 19, 2025 11:55
@AvivYossef-starkware AvivYossef-starkware force-pushed the aviv/bump_google_cloud_version branch from 7b443ef to 98996e9 Compare October 19, 2025 11:55
@AvivYossef-starkware AvivYossef-starkware changed the base branch from aviv/bump_google_cloud_version to graphite-base/9627 October 19, 2025 13:02
@AvivYossef-starkware AvivYossef-starkware changed the base branch from graphite-base/9627 to aviv/add_bench_mark_config October 19, 2025 13:02
Copy link
Collaborator

@avi-starkware avi-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@avi-starkware reviewed 5 of 6 files at r1, 1 of 1 files at r2, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @meship-starkware)


Cargo.toml line 386 at r2 (raw file):

void = "1.0.2"
waker-fn = "1.2.0"
walkdir = "2.5"

where is this used?

Code quote:

walkdir = "2.5"

bench_tools/src/gcs.rs line 12 at r2 (raw file):

///
/// Files are uploaded to: `gs://{BENCHMARKS_BUCKET}/{benchmark_name}/input/`
pub async fn upload_inputs(benchmark_name: &str, input_dir: &Path) {

why is async needed here?

Code quote:

pub async fn upload_inputs(benchmark_name: &str, input_dir: &Path) {

Copy link
Collaborator

@avi-starkware avi-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@avi-starkware reviewed 2 of 2 files at r4, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @AvivYossef-starkware and @meship-starkware)

@AvivYossef-starkware AvivYossef-starkware force-pushed the aviv/upload_input_files branch 2 times, most recently from a054ca2 to 8dea0ff Compare October 23, 2025 10:08
@graphite-app graphite-app bot changed the base branch from aviv/add_bench_mark_config to graphite-base/9627 October 23, 2025 10:08
Copy link
Collaborator

@avi-starkware avi-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@avi-starkware reviewed 2 of 2 files at r5, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @AvivYossef-starkware and @meship-starkware)

@graphite-app graphite-app bot changed the base branch from graphite-base/9627 to main-v0.14.1 October 23, 2025 10:25
@graphite-app
Copy link

graphite-app bot commented Oct 23, 2025

Merge activity

  • Oct 23, 10:25 AM UTC: Graphite rebased this pull request, because this pull request is set to merge when ready.

Copy link
Contributor Author

@AvivYossef-starkware AvivYossef-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 5 of 9 files reviewed, 1 unresolved discussion (waiting on @avi-starkware and @meship-starkware)


bench_tools/src/gcs.rs line 12 at r2 (raw file):

Previously, avi-starkware (Avi Cohen) wrote…

I don't mind using async, I just don't understand which other tasks tokio runs concurrently with this one

removed

Copy link
Contributor Author

@AvivYossef-starkware AvivYossef-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@AvivYossef-starkware reviewed 3 of 4 files at r6, all commit messages.
Reviewable status: 8 of 9 files reviewed, all discussions resolved (waiting on @avi-starkware and @meship-starkware)

Copy link
Collaborator

@avi-starkware avi-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@avi-starkware reviewed 4 of 4 files at r6, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @meship-starkware)

@AvivYossef-starkware AvivYossef-starkware added this pull request to the merge queue Oct 27, 2025
Merged via the queue into main-v0.14.1 with commit debf37a Oct 27, 2025
14 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Oct 28, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants