-
Notifications
You must be signed in to change notification settings - Fork 65
ci: upload benchmark input files #9627
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Benchmark movements: No major performance changes detected. |
4921a6c to
ee6a23c
Compare
19d43f5 to
7b443ef
Compare
cabf86b to
6721c60
Compare
7b443ef to
98996e9
Compare
98996e9 to
6e7b7de
Compare
6721c60 to
eaf5e9c
Compare
eaf5e9c to
5a06cee
Compare
avi-starkware
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@avi-starkware reviewed 5 of 6 files at r1, 1 of 1 files at r2, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @meship-starkware)
Cargo.toml line 386 at r2 (raw file):
void = "1.0.2" waker-fn = "1.2.0" walkdir = "2.5"
where is this used?
Code quote:
walkdir = "2.5"bench_tools/src/gcs.rs line 12 at r2 (raw file):
/// /// Files are uploaded to: `gs://{BENCHMARKS_BUCKET}/{benchmark_name}/input/` pub async fn upload_inputs(benchmark_name: &str, input_dir: &Path) {
why is async needed here?
Code quote:
pub async fn upload_inputs(benchmark_name: &str, input_dir: &Path) {6e7b7de to
fa36e02
Compare
5a06cee to
2e6702e
Compare
e440cbe to
9a9a4a4
Compare
8ddd9a2 to
80d78c1
Compare
9a9a4a4 to
e7f9a9f
Compare
80d78c1 to
ccc0714
Compare
avi-starkware
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@avi-starkware reviewed 2 of 2 files at r4, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @AvivYossef-starkware and @meship-starkware)
e7f9a9f to
ff74b5f
Compare
a054ca2 to
8dea0ff
Compare
avi-starkware
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@avi-starkware reviewed 2 of 2 files at r5, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @AvivYossef-starkware and @meship-starkware)
8dea0ff to
3f9493a
Compare
ff74b5f to
5b58d49
Compare
Merge activity
|
3f9493a to
7c75952
Compare
AvivYossef-starkware
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 5 of 9 files reviewed, 1 unresolved discussion (waiting on @avi-starkware and @meship-starkware)
bench_tools/src/gcs.rs line 12 at r2 (raw file):
Previously, avi-starkware (Avi Cohen) wrote…
I don't mind using async, I just don't understand which other tasks tokio runs concurrently with this one
removed
7c75952 to
9403273
Compare
AvivYossef-starkware
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@AvivYossef-starkware reviewed 3 of 4 files at r6, all commit messages.
Reviewable status: 8 of 9 files reviewed, all discussions resolved (waiting on @avi-starkware and @meship-starkware)
avi-starkware
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@avi-starkware reviewed 4 of 4 files at r6, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @meship-starkware)

No description provided.