bench_tools: save specific benchmark result #9742
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Oct 23, 2025
|
This change is |
This was referenced Oct 23, 2025
Contributor
Author
AvivYossef-starkware
requested review from
avi-starkware and
meship-starkware
avi-starkware
approved these changes
Oct 23, 2025
Collaborator
avi-starkware
left a comment
avi-starkware
left a comment
There was a problem hiding this comment.
@avi-starkware reviewed 1 of 1 files at r1, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @meship-starkware)
AvivYossef-starkware
force-pushed
the
aviv/add_criterion_benchmark_names
branch
from
3d11228 to
de34bd8
Compare
AvivYossef-starkware
force-pushed
the
aviv/save_specific_benchmark_result
branch
2 times, most recently
from
48e1a8f to
f159ab3
Compare
AvivYossef-starkware
force-pushed
the
aviv/add_criterion_benchmark_names
branch
from
de34bd8 to
1762d43
Compare
This was referenced Oct 28, 2025
Merged
AvivYossef-starkware
force-pushed
the
aviv/save_specific_benchmark_result
branch
from
f159ab3 to
bb05651
Compare
AvivYossef-starkware
force-pushed
the
aviv/add_criterion_benchmark_names
branch
2 times, most recently
from
39b0efd to
8e601c4
Compare
AvivYossef-starkware
force-pushed
the
aviv/save_specific_benchmark_result
branch
from
bb05651 to
531484f
Compare
avi-starkware
approved these changes
Oct 29, 2025
Collaborator
avi-starkware
left a comment
avi-starkware
left a comment
There was a problem hiding this comment.
@avi-starkware reviewed 1 of 1 files at r2, all commit messages.
Reviewable status:
graphite-app
bot
changed the base branch from
aviv/add_criterion_benchmark_names
to
graphite-base/9742
AvivYossef-starkware
force-pushed
the
aviv/save_specific_benchmark_result
branch
from
531484f to
ebc8aa8
Compare
AvivYossef-starkware
force-pushed
the
graphite-base/9742
branch
from
8e601c4 to
753f61c
Compare
graphite-app
bot
changed the base branch from
graphite-base/9742
to
main-v0.14.1
Merge activity
|
This was referenced Oct 30, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.