bench_tools: support deserialization of criterion change #9698
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Oct 22, 2025
|
This change is |
This was referenced Oct 22, 2025
Contributor
Author
AvivYossef-starkware
requested review from
avi-starkware and
meship-starkware
AvivYossef-starkware
force-pushed
the
aviv/add_criterion_benchmark_names
branch
from
b9b7dff to
a7cbb4d
Compare
AvivYossef-starkware
force-pushed
the
aviv/support_deserialization_of_criterion_change
branch
from
22fdd6e to
8c3ca65
Compare
AvivYossef-starkware
force-pushed
the
aviv/add_criterion_benchmark_names
branch
from
a7cbb4d to
d43c70f
Compare
AvivYossef-starkware
force-pushed
the
aviv/support_deserialization_of_criterion_change
branch
from
8c3ca65 to
7e56c55
Compare
AvivYossef-starkware
force-pushed
the
aviv/add_criterion_benchmark_names
branch
from
d43c70f to
e3895bb
Compare
AvivYossef-starkware
force-pushed
the
aviv/support_deserialization_of_criterion_change
branch
from
7e56c55 to
87beeaa
Compare
avi-starkware
approved these changes
Oct 22, 2025
Collaborator
avi-starkware
left a comment
avi-starkware
left a comment
There was a problem hiding this comment.
@avi-starkware reviewed 1 of 1 files at r1, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @meship-starkware)
This was referenced Oct 22, 2025
AvivYossef-starkware
force-pushed
the
aviv/support_deserialization_of_criterion_change
branch
from
87beeaa to
c9df6fa
Compare
AvivYossef-starkware
force-pushed
the
aviv/add_criterion_benchmark_names
branch
from
e3895bb to
618a391
Compare
AvivYossef-starkware
force-pushed
the
aviv/support_deserialization_of_criterion_change
branch
from
c9df6fa to
595e682
Compare
AvivYossef-starkware
force-pushed
the
aviv/add_criterion_benchmark_names
branch
2 times, most recently
from
0b8e2f7 to
a6d3b63
Compare
AvivYossef-starkware
force-pushed
the
aviv/support_deserialization_of_criterion_change
branch
from
595e682 to
84e9328
Compare
AvivYossef-starkware
changed the base branch from
aviv/add_criterion_benchmark_names
to
graphite-base/9698
AvivYossef-starkware
force-pushed
the
graphite-base/9698
branch
from
a6d3b63 to
d0a108d
Compare
AvivYossef-starkware
force-pushed
the
aviv/support_deserialization_of_criterion_change
branch
from
84e9328 to
947e4cc
Compare
AvivYossef-starkware
changed the base branch from
graphite-base/9698
to
aviv/save_specific_benchmark_result
AvivYossef-starkware
force-pushed
the
aviv/support_deserialization_of_criterion_change
branch
from
947e4cc to
a033588
Compare
AvivYossef-starkware
force-pushed
the
aviv/save_specific_benchmark_result
branch
2 times, most recently
from
48e1a8f to
f159ab3
Compare
AvivYossef-starkware
force-pushed
the
aviv/support_deserialization_of_criterion_change
branch
from
a033588 to
47a9439
Compare
This was referenced Oct 28, 2025
Merged
AvivYossef-starkware
force-pushed
the
aviv/support_deserialization_of_criterion_change
branch
from
47a9439 to
fbfbf8e
Compare
AvivYossef-starkware
force-pushed
the
aviv/save_specific_benchmark_result
branch
from
f159ab3 to
bb05651
Compare
AvivYossef-starkware
force-pushed
the
aviv/support_deserialization_of_criterion_change
branch
from
fbfbf8e to
8f40da5
Compare
AvivYossef-starkware
force-pushed
the
aviv/save_specific_benchmark_result
branch
from
bb05651 to
531484f
Compare
graphite-app
bot
changed the base branch from
aviv/save_specific_benchmark_result
to
graphite-base/9698
AvivYossef-starkware
force-pushed
the
aviv/support_deserialization_of_criterion_change
branch
from
8f40da5 to
32ac829
Compare
AvivYossef-starkware
force-pushed
the
graphite-base/9698
branch
from
531484f to
dda2576
Compare
graphite-app
bot
changed the base branch from
graphite-base/9698
to
main-v0.14.1
Merge activity
|
This was referenced Oct 30, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.