- 
                Notifications
    You must be signed in to change notification settings 
- Fork 899
Add Third Reality soil sensor settings #4380
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: dev
Are you sure you want to change the base?
Conversation
| Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@            Coverage Diff             @@
##              dev    #4380      +/-   ##
==========================================
+ Coverage   92.12%   92.19%   +0.06%     
==========================================
  Files         358      366       +8     
  Lines       11917    12019     +102     
==========================================
+ Hits        10979    11081     +102     
  Misses        938      938              ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
 | 
| temperature_correction_fahrenheit: Final = ZCLAttributeDef( | ||
| id=0x0033, | ||
| type=t.int16s, | ||
| is_manufacturer_specific=True, | ||
| ) | ||
|  | ||
| temperature_correction_celsius: Final = ZCLAttributeDef( | ||
| id=0x0031, | ||
| type=t.int16s, | ||
| is_manufacturer_specific=True, | ||
| ) | 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this device (also) have a display or why is the temperature correction for Celsius and Fahrenheit separate?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is no display screen, and the reason for separating Celsius and Fahrenheit is that some users use Celsius and Fahrenheit, so they can calibrate freely according to the unit without the need for additional conversion
| If we add the temperature device class two the two temperature offset entities, I believe HA switches the entities to be in the preferred unit for the user. 
 Also see: | 
| 
 There is no difference between temperature C ° and F °. Setting one of them will convert the other into the corresponding value according to the formula, just for the convenience of the user. If it is possible to achieve the same calibration unit as the temperature unit set by the user, it would be even better | 
Proposed change
This PR added adaptation code for soil sensor and added 3 additional private clusters
Additional information
Device diagnostics
Checklist
pre-commitchecks pass / the code has been formatted using Black