[BUG FIX] Clarify IPC vertex constraint error#3056
Merged
duburcqa merged 2 commits intoJul 21, 2026
Conversation
duburcqa
approved these changes
Jul 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Clarify the error raised by
FEMEntity.set_vertex_constraints()when anIPCCoupleris active. The guard intentionally rejects this call because IPC owns the FEM state, but the previous message said the method was only supported by IPC—the opposite of the implemented behavior.This changes the message to state that vertex constraints are not supported by the IPC coupler and adds a required regression test for that rejection path. Simulation behavior is unchanged.
Related Issue
Resolves #3039
Motivation and Context
Users currently cannot tell whether the IPC type check is inverted or the exception text is wrong. IPC maintains and writes back its own FEM geometry state, while the vertex-constraint kernels belong to the FEM solver, so retaining the guard and correcting its message makes the existing limitation explicit.
How Has This Been / Can This Be Tested?
pre-commit run --files genesis/engine/entities/fem_entity.py tests/deformable/test_fem.py --show-diff-on-failurepytest -p no:cacheprovider -v -ra --logical --dev --backend cpu -m 'required and not slow' --forked tests/deformable/test_fem.py(9 passed, 1 expected xfail)Screenshots (if appropriate):
Not applicable; this changes an API error message and test coverage only.
Checklist:
Submitting Code Changessection of CONTRIBUTING document.