Skip to content

ENH: Add script availability testing#154

Merged
ljod merged 1 commit intoSlicerDMRI:masterfrom
jhlegarreta:AddScriptAvailabilityTesting
Oct 5, 2023
Merged

ENH: Add script availability testing#154
ljod merged 1 commit intoSlicerDMRI:masterfrom
jhlegarreta:AddScriptAvailabilityTesting

Conversation

@jhlegarreta
Copy link
Copy Markdown
Contributor

@jhlegarreta jhlegarreta commented Sep 15, 2023

Add script availability testing: ensure that scripts can be called by testing the call with the help flag to show the script documentation.

Add the necessary package dependencies to discover and run the tests.

Make the GHA workflow actually run the tests: uncomment the corresponding statement.

@jhlegarreta jhlegarreta force-pushed the AddScriptAvailabilityTesting branch 3 times, most recently from 28bbc67 to 0c185f2 Compare October 5, 2023 01:21
@jhlegarreta
Copy link
Copy Markdown
Contributor Author

jhlegarreta commented Oct 5, 2023

This is working locally. Screenshots:

wma_test_run_error

wma_pytest

wma_pytest_o_junit_family-xunit2-v-doctest-modules

And also on GitHub (24 items are collected): https://github.com/SlicerDMRI/whitematteranalysis/actions/runs/6413452971/job/17412380161?pr=154#step:5:686

So this identifies a few issues that need to be address in separate PRs:

@jhlegarreta jhlegarreta marked this pull request as ready for review October 5, 2023 01:24
This was referenced Oct 5, 2023
@jhlegarreta jhlegarreta force-pushed the AddScriptAvailabilityTesting branch from 0c185f2 to a103225 Compare October 5, 2023 12:28
Add script availability testing: ensure that scripts can be called by
testing the call with the help flag to show the script documentation.

Add the corresponding `__init__.py` files so that the scripts can be
discovered.

Add the necessary package dependencies to discover and run the tests.

Make the GHA workflow actually run the tests: call `pytest` to collect
tests.
@jhlegarreta jhlegarreta force-pushed the AddScriptAvailabilityTesting branch from a103225 to cf5ddd8 Compare October 5, 2023 12:47
Copy link
Copy Markdown
Member

@ljod ljod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you

@ljod ljod merged commit 25d1f04 into SlicerDMRI:master Oct 5, 2023
@jhlegarreta jhlegarreta deleted the AddScriptAvailabilityTesting branch October 5, 2023 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants