feat(i18n): add complete Latin American Spanish (es) UI translation catalogs - #1047
Open
kauenet wants to merge 1 commit into
Open
feat(i18n): add complete Latin American Spanish (es) UI translation catalogs#1047kauenet wants to merge 1 commit into
kauenet wants to merge 1 commit into
Conversation
|
@kauenet is attempting to deploy a commit to the Solana Foundation Team on Vercel. A member of the Team first needs to authorize it. |
Contributor
Greptile SummaryThe PR adds complete Latin American Spanish catalogs and registers the locale in the dashboard’s i18n configuration.
Confidence Score: 5/5The PR appears safe to merge, with only non-blocking Spanish terminology cleanup remaining in an existing review thread. The previously reported removal terminology mismatch remains in the Spanish catalogs, but no blocking failure remains. Files Needing Attention: apps/sdp-web/messages/es/shared.json, apps/sdp-web/messages/es/dashboard-payments.json, apps/sdp-web/messages/es/dashboard-custody.json Important Files Changed
Reviews (4): Last reviewed commit: "feat(i18n): add complete Latin American ..." | Re-trigger Greptile |
kauenet
force-pushed
the
feat/i18n-es-catalogs-01-08-2026
branch
from
August 4, 2026 14:05
e4e44ff to
9f1ced9
Compare
…atalogs Adds full es catalogs for all 3,639 UI strings across the 8 message files, including dashboard-private-channels (not yet covered by fr). Registers the locale in supportedLocales/messagesByLocale, extends the i18n unit tests, and adds the locales.es terminology block (voice, glossary-driven terminology, forbiddenTerms) to translation-guidance.json so catalog validation enforces the conventions from day one. Terminology follows solanabr/solana-glossary and the established fr precedent: Token, Wallet, mint/burn, allowlist/blocklist, endpoint, API Playground and friends stay in English; generic finance/CS vocabulary uses neutral Latin American Spanish (activo, contraparte, transferencia, cotización, proveedor). Register: tú, never vosotros.
kauenet
force-pushed
the
feat/i18n-es-catalogs-01-08-2026
branch
from
August 4, 2026 16:11
9f1ced9 to
969e90c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
es) catalogs for all 3,639 UI strings across the 8 message files — includingdashboard-private-channels.json(272 keys), whichfrdoes not cover yet.esinsupportedLocales/messagesByLocale; the language picker andAccept-Languageresolution (es,es-MX,es-AR, …) pick it up automatically.locales.esterminology block (voice, glossary-driven terminology,forbiddenTerms) to.github/translation-guidance.json, so catalog validation and the Eve release workflow enforce the conventions on every future string.Terminology
frconventions.Token,Wallet,mint/burn,allowlist/blocklist,endpoint,API Playground,Sandbox,stablecoin,on-chain/off-chain,staking, the SPL authority family (Mint/Freeze/Update/Metadata Authority,Permanent Delegate),ramp/on-ramp/off-ramp,rails,rent.activo,contraparte,transferencia,cotización,proveedor,custodia,custodio,decimales,cumplimiento,pago saliente(payout),fondeo(funding);tarifafor network/transaction fees vscomisiónfor provider fees.tú/ustedes(nevervosotros), inverted¿ ¡. Forbidden (regex-enforced):billetera,monedero,cartera,ficha,acuñar,zona de pruebas,lista blanca/negra.Quality process
en; placeholder tokens byte-identical; zero forbidden-term hits.Policy
Dedicated translation-only PR per
check-catalog-change-policy.mjs— zero English catalog changes.Validation
validateCatalogs(missing keys + placeholder parity + forbidden terms): es fully validvitest src/i18n/messages.unit.test.ts(inventory parity, typed lookups, fallback): passtsc --noEmit(sdp-web) — catalogs type-checked viasatisfies LocalizedMessages<Messages>: passpnpm test:scripts(catalog policy + release translation tooling): passAccept-Language(es,es-MX) resolve toes; landing and dashboard surfaces render translated;en/frunaffected.