starknet_committer_cli: use Box<dyn Storage> for storage init #9851
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
Collaborator
Author
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
This was referenced Oct 29, 2025
dorimedini-starkware
requested review from
nimrod-starkware and
rotem-starkware
dorimedini-starkware
force-pushed
the
10-29-starknet_committer_starknet_patricia_don_t_use_impl_storage_use_generics
branch
from
a01772e to
85638af
Compare
dorimedini-starkware
force-pushed
the
10-29-starknet_committer_cli_use_box_dyn_storage_for_storage_init
branch
from
db97ed3 to
d9a8059
Compare
nimrod-starkware
approved these changes
Oct 30, 2025
Contributor
nimrod-starkware
left a comment
nimrod-starkware
left a comment
There was a problem hiding this comment.
@nimrod-starkware reviewed 2 of 2 files at r1, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @rotem-starkware)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.