Skip to content

Conversation

@dorimedini-starkware
Copy link
Collaborator

No description provided.

@reviewable-StarkWare
Copy link

This change is Reviewable

Copy link
Collaborator Author

dorimedini-starkware commented Oct 29, 2025

Copy link
Collaborator Author

@dorimedini-starkware dorimedini-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 10 files reviewed, all discussions resolved (waiting on @nimrod-starkware and @rotem-starkware)


a discussion (no related file):
without this change, the next PR (passing Box<dyn Storage>) is not possible

@github-actions
Copy link

Benchmark movements: No major performance changes detected.

Copy link
Contributor

@nimrod-starkware nimrod-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

@nimrod-starkware reviewed 10 of 10 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @rotem-starkware)


crates/starknet_committer/src/block_committer/commit.rs line 26 at r1 (raw file):

type BlockCommitmentResult<T> = Result<T, BlockCommitmentError>;

pub async fn commit_block<S: Storage + ?Sized>(

Can you please explain why is it needed?

Code quote:

S: Storage + ?Sized

Copy link
Contributor

@nimrod-starkware nimrod-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @rotem-starkware)

@dorimedini-starkware dorimedini-starkware force-pushed the 10-29-starknet_patricia_storage_add_short-key_storage branch from aa50217 to 8ce732f Compare October 29, 2025 19:41
@dorimedini-starkware dorimedini-starkware force-pushed the 10-29-starknet_committer_starknet_patricia_don_t_use_impl_storage_use_generics branch from a01772e to 85638af Compare October 29, 2025 19:41
@github-actions github-actions bot locked and limited conversation to collaborators Nov 1, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants