-
Notifications
You must be signed in to change notification settings - Fork 65
starknet_committer,starknet_patricia: don't use impl Storage, use generics #9850
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This stack of pull requests is managed by Graphite. Learn more about stacking. |
dorimedini-starkware
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 0 of 10 files reviewed, all discussions resolved (waiting on @nimrod-starkware and @rotem-starkware)
a discussion (no related file):
without this change, the next PR (passing Box<dyn Storage>) is not possible
|
Benchmark movements: No major performance changes detected. |
nimrod-starkware
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@nimrod-starkware reviewed 10 of 10 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @rotem-starkware)
crates/starknet_committer/src/block_committer/commit.rs line 26 at r1 (raw file):
type BlockCommitmentResult<T> = Result<T, BlockCommitmentError>; pub async fn commit_block<S: Storage + ?Sized>(
Can you please explain why is it needed?
Code quote:
S: Storage + ?Sized
nimrod-starkware
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status:
complete! all files reviewed, all discussions resolved (waiting on @rotem-starkware)
aa50217 to
8ce732f
Compare
a01772e to
85638af
Compare

No description provided.