starknet_committer_cli: add option for key size

[dorimedini-starkware]

No description provided.

[dorimedini-starkware]

• starknet_committer_cli: couple the key size arg with the valid values #9875
• starknet_committer_cli: add option for key size #9852 👈 (View in Graphite)
• starknet_committer_cli: reduce boilerplate without using Box<dyn Storage> #9865
• starknet_patricia_storage: add short-key storage #9849 : 1 other dependent PR (#9850 )
• main-v0.14.1-committer

This stack of pull requests is managed by Graphite. Learn more about stacking.

[reviewable-StarkWare]

This change is 

[nimrod-starkware]

@nimrod-starkware reviewed 2 of 3 files at r1, 1 of 1 files at r2, 1 of 1 files at r3, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @rotem-starkware)

---

crates/starknet_patricia_storage/src/short_key_storage.rs line 48 at r2 (raw file):

                size => panic!("Invalid key size {size}."),
            }
        }

Please mention that the given sizes need to be in [16, 32]

Code quote:

        /// Wrap an existing storage implementation in a boxed short key storage implementation.
        /// If no size is given, boxes and returns the original storage.
        /// Panics if the size is not within the allowed range.
        pub fn wrap_storage_or_panic<S: Storage + 'static>(
            size: Option<u8>,
            storage: S,
        ) -> Box<dyn Storage> {
            let Some(size) = size else {
                return Box::new(storage);
            };
            match size {
                $( $sizes => Box::new($names::new(storage)), )+
                size => panic!("Invalid key size {size}."),
            }
        }

[dorimedini-starkware]

Reviewable status: 0 of 3 files reviewed, 1 unresolved discussion (waiting on @nimrod-starkware and @rotem-starkware)

---

crates/starknet_patricia_storage/src/short_key_storage.rs line 48 at r2 (raw file):

Previously, nimrod-starkware wrote…

Please mention that the given sizes need to be in [16, 32]

I prefer to keep a single point of truth... if I change the 16..=32 range in the short_key module I will not remember to change the panic message (and if someone else adds new byte ranges, even worse)

[dorimedini-starkware]

Reviewable status: 0 of 3 files reviewed, 2 unresolved discussions (waiting on @nimrod-starkware and @rotem-starkware)

---

crates/starknet_committer_cli/src/bin/benchmark_run/Dockerfile line 35 at r4 (raw file):

    "--n-diffs", "4000", \
    "--storage-type", "cached-mdbx", \
    "--key-size", "16", \

should we use this default? or keep it None?

Code quote:

"--key-size", "16", \

[dorimedini-starkware]

Reviewable status: 0 of 3 files reviewed, 2 unresolved discussions (waiting on @nimrod-starkware and @rotem-starkware)

---

crates/starknet_patricia_storage/src/short_key_storage.rs line 48 at r2 (raw file):

Previously, dorimedini-starkware wrote…

I prefer to keep a single point of truth... if I change the 16..=32 range in the short_key module I will not remember to change the panic message (and if someone else adds new byte ranges, even worse)

the next PR should address your concerns

[nimrod-starkware]

@nimrod-starkware reviewed 3 of 3 files at r4, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @rotem-starkware)

---

crates/starknet_committer_cli/src/bin/benchmark_run/Dockerfile line 35 at r4 (raw file):

Previously, dorimedini-starkware wrote…

should we use this default? or keep it None?

I think the default should be None, @rotem-starkware wdyt?

[dorimedini-starkware]

Reviewable status: 2 of 3 files reviewed, 1 unresolved discussion (waiting on @nimrod-starkware and @rotem-starkware)

---

crates/starknet_committer_cli/src/bin/benchmark_run/Dockerfile line 35 at r4 (raw file):

Previously, nimrod-starkware wrote…

I think the default should be None, @rotem-starkware wdyt?

Done.

[rotem-starkware]

@rotem-starkware reviewed 1 of 3 files at r4, 1 of 1 files at r5, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @dorimedini-starkware)

[nimrod-starkware]

@nimrod-starkware reviewed all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @dorimedini-starkware)