-
Notifications
You must be signed in to change notification settings - Fork 65
starknet_patricia_storage: add short-key storage #9849
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
starknet_patricia_storage: add short-key storage #9849
Conversation
This stack of pull requests is managed by Graphite. Learn more about stacking. |
|
Artifacts upload workflows: |
|
Benchmark movements: tree_computation_flow performance regressed! tree_computation_flow time: [15.478 ms 15.648 ms 15.816 ms] change: [+1.9142% +4.1014% +6.1626%] (p = 0.00 < 0.05) Performance has regressed. Found 2 outliers among 100 measurements (2.00%) 2 (2.00%) high mild |
nimrod-starkware
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@nimrod-starkware reviewed 4 of 4 files at r1, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @rotem-starkware)
crates/starknet_patricia_storage/src/short_key_storage.rs line 36 at r1 (raw file):
($size:ty, $name:ident) => { /// A storage that hashes each key to a $size - byte key.
worth mentioning we are using blake IMO
Suggestion:
/// A storage that hashes using blake each key to a $size - byte key.crates/starknet_patricia_storage/src/short_key_storage.rs line 39 at r1 (raw file):
pub struct $name<S: Storage> { storage: S, _bytes: PhantomData<$size>,
non-blocking
Suggestion:
_n_bytes: PhantomData<$size>,
dorimedini-starkware
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @nimrod-starkware and @rotem-starkware)
crates/starknet_patricia_storage/src/short_key_storage.rs line 36 at r1 (raw file):
Previously, nimrod-starkware wrote…
worth mentioning we are using blake IMO
Done.
aa50217 to
8ce732f
Compare
nimrod-starkware
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@nimrod-starkware reviewed 1 of 1 files at r2, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @rotem-starkware)
rotem-starkware
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@rotem-starkware reviewed 3 of 4 files at r1, 1 of 1 files at r2, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @dorimedini-starkware)
ec8d853

No description provided.