Skip to content

Conversation

@dorimedini-starkware
Copy link
Collaborator

No description provided.

@reviewable-StarkWare
Copy link

This change is Reviewable

Copy link
Collaborator Author

dorimedini-starkware commented Oct 29, 2025

This stack of pull requests is managed by Graphite. Learn more about stacking.

@github-actions
Copy link

github-actions bot commented Oct 29, 2025

Artifacts upload workflows:

@github-actions
Copy link

github-actions bot commented Oct 29, 2025

Benchmark movements: tree_computation_flow performance regressed! tree_computation_flow time: [15.478 ms 15.648 ms 15.816 ms] change: [+1.9142% +4.1014% +6.1626%] (p = 0.00 < 0.05) Performance has regressed. Found 2 outliers among 100 measurements (2.00%) 2 (2.00%) high mild

Copy link
Contributor

@nimrod-starkware nimrod-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nimrod-starkware reviewed 4 of 4 files at r1, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @rotem-starkware)


crates/starknet_patricia_storage/src/short_key_storage.rs line 36 at r1 (raw file):

    ($size:ty, $name:ident) => {
        /// A storage that hashes each key to a $size - byte key.

worth mentioning we are using blake IMO

Suggestion:

/// A storage that hashes using blake each key to a $size - byte key.

crates/starknet_patricia_storage/src/short_key_storage.rs line 39 at r1 (raw file):

        pub struct $name<S: Storage> {
            storage: S,
            _bytes: PhantomData<$size>,

non-blocking

Suggestion:

_n_bytes: PhantomData<$size>,

Copy link
Collaborator Author

@dorimedini-starkware dorimedini-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @nimrod-starkware and @rotem-starkware)


crates/starknet_patricia_storage/src/short_key_storage.rs line 36 at r1 (raw file):

Previously, nimrod-starkware wrote…

worth mentioning we are using blake IMO

Done.

@dorimedini-starkware dorimedini-starkware force-pushed the 10-29-starknet_patricia_storage_add_short-key_storage branch from aa50217 to 8ce732f Compare October 29, 2025 19:41
Copy link
Contributor

@nimrod-starkware nimrod-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

@nimrod-starkware reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @rotem-starkware)

Copy link
Contributor

@rotem-starkware rotem-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

@rotem-starkware reviewed 3 of 4 files at r1, 1 of 1 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @dorimedini-starkware)

@dorimedini-starkware dorimedini-starkware added this pull request to the merge queue Oct 30, 2025
Merged via the queue into main-v0.14.1-committer with commit ec8d853 Oct 30, 2025
43 of 48 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Nov 1, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants