Add Third Reality temperature and humidity sensor lite settings #4387
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## dev #4387 +/- ##
==========================================
+ Coverage 92.12% 92.17% +0.04%
==========================================
Files 358 364 +6
Lines 11917 11992 +75
==========================================
+ Hits 10979 11054 +75
Misses 938 938 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
TheJulianJES
added
the
manufacturer
There was a problem hiding this comment.
This can be combined with the quirk from #4386.
The PollControl cluster can be removed in a separate quirk which clones the main quirk for all the functionality. I'll merge these PRs separately for now, but I'll tag you in a PR where I merge these later.
zhaquirks/thirdreality/temperature_and_humidity_sensor_lite_v2.py
Outdated
Show resolved
Hide resolved
zhaquirks/thirdreality/temperature_and_humidity_sensor_lite_v2.py
Outdated
Show resolved
Hide resolved
| min_value=-10000, | ||
| max_value=10000, |
There was a problem hiding this comment.
Isn't this a bit much to allow for?
There was a problem hiding this comment.
You can just use mode="box" if you always want to force a box, instead of a slider in the HA UI.
There was a problem hiding this comment.
Ah, I didn't notice the multiplier=0.01. This is likely fine then.
| from zigpy.zcl.foundation import BaseAttributeDefs, ZCLAttributeDef | ||
|
|
||
|
|
||
| class ThirdRealityTemperatureAndHumidityCluster(CustomCluster): |
There was a problem hiding this comment.
I'll likely shorten this class name a bit in a follow-up PR, where I can go over all of the added Third Reality quirks.
| min_value=-10000, | ||
| max_value=10000, |
There was a problem hiding this comment.
Ah, I didn't notice the multiplier=0.01. This is likely fine then.
TheJulianJES
changed the title
|
The same question in #4380 also applies to this device/quirk. |
3 participants
Proposed change
This PR added adaptation code for T_H sensor lite and added 3 additional private clusters
Additional information
Device diagnostics
Checklist
pre-commitchecks pass / the code has been formatted using Black