Skip to content

Conversation

@3reality-support
Copy link
Contributor

@3reality-support 3reality-support commented Oct 10, 2025

Proposed change

This PR added adaptation code for T_H sensor and added 3 additional private clusters

  1. temperature_correction_fahrenheit: Calibrate Fahrenheit
  2. temperature_correction_celsius: Calibrate Celsius
  3. humidity_correction: Calibrate humidity

Additional information

8d0fef7efb0f9e50279a95f0d18095a5

Device diagnostics

Checklist

  • The changes are tested and work correctly
  • pre-commit checks pass / the code has been formatted using Black
  • Tests have been added to verify that the new code works
  • Device diagnostics data has been attached

@codecov
Copy link

codecov bot commented Oct 10, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.18%. Comparing base (500e74e) to head (7604983).
⚠️ Report is 11 commits behind head on dev.

Additional details and impacted files
@@            Coverage Diff             @@
##              dev    #4386      +/-   ##
==========================================
+ Coverage   92.12%   92.18%   +0.05%     
==========================================
  Files         358      365       +7     
  Lines       11917    12005      +88     
==========================================
+ Hits        10979    11067      +88     
  Misses        938      938              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@TheJulianJES TheJulianJES added the manufacturer This request was made by the device's manufacturer label Oct 10, 2025
@TheJulianJES TheJulianJES changed the title Add Third Reality T_H sensor settings Add Third Reality temperature and humidity sensor settings Oct 28, 2025
- move `cluster_id`
- add device classes
- rename "calibration" to "offset"
Copy link
Collaborator

@TheJulianJES TheJulianJES left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cleaned up similar to #4387.
I'll combine those quirks in a future PR, since they're very similar: only the PollControl should be removed for just the one sensor. I'll make sure to do that, but we can still use clone() on a base quirk.

@TheJulianJES
Copy link
Collaborator

I might rename "correction" to "offset" in the attribute names as well then. That will change the unique ID, so if you might see new config entities appear in your dev environment for these devices when running the new versions later. That's expected, as you ran the initial version with the old names.

@TheJulianJES TheJulianJES merged commit 203b56f into zigpy:dev Oct 28, 2025
9 checks passed
@TheJulianJES
Copy link
Collaborator

The same question in #4380 also applies to this device/quirk.
Please answer in the linked PR (soil sensor).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

manufacturer This request was made by the device's manufacturer

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants