starknet_committer_cli: reduce boilerplate without using Box<dyn Storage> #9865
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
This was referenced Oct 30, 2025
Collaborator
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
dorimedini-starkware
requested review from
nimrod-starkware and
rotem-starkware
dorimedini-starkware
force-pushed
the
10-30-starknet_committer_cli_reduce_boilerplate_without_using_box_dyn_storage_
branch
from
3b43ea2 to
964dec5
Compare
dorimedini-starkware
changed the base branch from
10-29-starknet_patricia_storage_add_short-key_storage
to
main-v0.14.1-committer
|
Artifacts upload workflows: |
|
Benchmark movements: No major performance changes detected. |
nimrod-starkware
approved these changes
Oct 30, 2025
Contributor
nimrod-starkware
left a comment
nimrod-starkware
left a comment
There was a problem hiding this comment.
@nimrod-starkware reviewed 1 of 1 files at r1, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @rotem-starkware)
rotem-starkware
approved these changes
Nov 2, 2025
Contributor
rotem-starkware
left a comment
rotem-starkware
left a comment
There was a problem hiding this comment.
@rotem-starkware reviewed 1 of 1 files at r1, all commit messages.
Reviewable status:
Merged
via the queue into
main-v0.14.1-committer
with commit Nov 2, 2025
8fd1036
28 of 34 checks passed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.